• 0 Posts
  • 29 Comments
Joined 1 year ago
cake
Cake day: March 31st, 2025

help-circle

  • First off, don’t sweat it, the “nightmare” was probably 20-30 annoying minutes for the senior.

    But commit count isn’t what would’ve made it tough to merge, and strictly speaking smaller commits is typically better.

    Concretely: limit the kinds and the reach of changes you’re asking someone to review & merge. I’ve never done localization but I’ll try to guess for an example -

    1000 lines changed because you’re replacing an incorrect punctuation character misused everywhere - that’s really only one change to have to think about, it’s 1000 lines but one fairly trivial change.

    Now, if each of those lines was improving some phrasing, done by a native speaker that found existing phrasing clunky for their language? Well, each of those are their own judgment call and have to be assessed individually. A thousand fairly subtle changes, and a PR isn’t meant to accept some and reject others.

    More abstractly, try to put yourself in the reviewer’s shoes (hard when new) - how much stuff do they have to keep in mind in order to make judgment calls about this whole batch of code?

    More if you want it:

    spoiler

    Moving on from localization, ask yourself, how many “places” in the codebase does your code touch? Are you lumping every single possible thing into a single change set because it feels like a single feature, when it could have been architecturally segmented? Like sure a single PR for a single overall feature makes sense conceptually, but can it be split? Your skill with splitting up tasks is like 70% of your skill as an engineer over time, btw.

    So for example, single feature - all code and PR for DB models, separate PR for API updates, separate PR for UI updates. One feature but the UI folks don’t have to think about the other parts, etc. Maybe the ideal case is obvious.

    There are always complicating factors. Some tasks aren’t well suited to that segmentation and really require big far reaching changes. Some codebases (bad ones) make it impossible to change one part without touching ~all of it.

    When you’re starting out, doing this reliably well requires seniors scoping out tasks properly so that they are developed (and then reviewed) in a sensible, segmented way.


  • Generally it’s more considerate to submit smaller batches of (self-contained!) work at a time. Sometimes the work or existing code is so interconnected that this can’t really be done, though. You mentioned spending a month, that’s also a long time in most environments to be off working on bulk changes for later review. A week is probably long enough in most cases, some orgs even prefer to push (if not review) code daily.

    Don’t agonize over it though, wanting to improve your impact on others while working is the right direction to point, keep walking that way and you’ll do awesome, let it develop over time. As in, don’t let your desire for politeness slow down your work or growth too much (I do this lol, why I’m mentioning).




  • This American Life and The Moth may not be quite the format you’re describing but if you’re not familiar, they are old (big backlog), and quality and tend to feature viewpoints from the ordinary and even marginalized, both in their own ways.

    Actually when I think about it, unless I’m misremembering, This American Life did a piece on body dysmorphia long before that concept reached more mainstream awareness. I don’t know how I’d feel about it now (I’ve just learned a lot since and it’s been like 10 years or something), but at the time I remember finding it compassionate and insightful, really opened my eyes on something I was previously only dimly aware of and curious about, before.


  • As is often the case in the US, without someone chiming in with a bunch of specifics, it’s hard to understand the scope of what I mean as being as dark as it is. We institutionally went from “no pain is allowed in patients, load em up!” to “patients can fucking deal with it, it probably doesn’t even hurt that much”, overnight, we didn’t land at any semblance of a sane middle ground. Hopefully the pendulum swings will behave like a real pendulum and settle lower and lower, but woof, it’s bad out there.


  • It gets worse. There was nothing done for the people whose doctors told them these drugs were safe and non addicting and totally fine to take for their ankle sprain or whatever (slight exaggeration, maybe, but truly slight).

    They experienced the same sudden guillotine chop of subscription willingness with no support, mid-addiction.

    So yeah all those people the Sacklers got rich by lying to and addicting, they’re just dead now or homeless and on their way there. Damn near to a rule, cuz opiate addiction often can’t be beat at all, and almost never without real support.

    It’s grim. But the dead and ruined, their voices don’t rise to anywhere that people with decision-making power can hear. And that’s how our country works, in a nutshell - if you mistreat people a bit, they complain. If you mistreat people all the way, though, they die and go otherwise silent. Forget leopards and their face buffet, we live in a full-on meat grinder.


  • I can’t quite put my finger on moments like yours, but had the same strange sensation of creeping revulsion toward NPR, where it once felt like a safe, familiar, even comforting, thing.

    NPR, in a million ways small and large, carries water for the status quo, and it’s fuckin gross. Even just small ongoing things like their current phrasing “the war in Iran”. It’s an anodyne, neutral phrasing used in their broadcasts, seemingly as a rule. Same neutral language for cops when “an assailant was shot and died”, or when “a weapon discharged”, etc.

    It’s never the war against Iran, it’s not “the unprovoked attack against Iran”, etc., it’s just this vague inscrutable thing merely happening, and merely in Iran. No one is responsible, and it just is there. And thankfully, it’s only IN Iran! Wouldn’t it be worse if that were spilling over into other places and things?

    There are countless stronger examples, but this one is current and consistent and you can hear it in any random news broadcast, and it tells a huge lie in a tiny word every time.



  • This doesn’t contradict what I’m saying, but maybe you didn’t intend to. The person I knew well and was describing would be described even worse by his own teachers - in fact his teachers insisted he go into classes catering to kids with severe learning disabilities. Which he was beaten for at home, and caused him huge unanswered shame.

    But again, he could basically instantly understand the motivations of a room full of strangers, it was uncanny. Even other people I know who are good at it, not like this. And he would get bored and put people in weird situations to entertain himself, using this power. They never saw what he was doing.

    Trump is fucking horrible at almost everything. He’s not quite dumb though, really clearly not. He’s unable and unwilling to direct his mind toward anything other than a specific narrow set of goals, and this person I knew was exactly that way.

    But pursuit of one of his goals? He’d fucking get there. He would get there. And it was sometimes horrifying, and often base and mean, but it could just be a lot of egregious flattery too - whatever the situation called for. Scary stuff.